[T5.4] - stack js not minified

Discussion:

Bård Magnus Kvalheim

2013-11-10 14:55:56 UTC

Hi guys.

Just noised that stack js in not minified in 5.4.
Tried on 5.4.22 and 5.4.24 and seems to be missing on both.

I'm in production mode and have also set
combine-scripts=true
enable-minification=true

Modules and asset js + css seem to all minify correctly, so look like a
possible oversight for stacks?

Let me know if anyone can confirm/reproduce and a JIRA should be created.

Cheers
Magnus

Howard Lewis Ship

2013-11-11 17:08:15 UTC

Permalink

That sounds like an oversight, and I'm a bit surprised!

Post by BÃ¥rd Magnus Kvalheim
Hi guys.
Just noised that stack js in not minified in 5.4.
Tried on 5.4.22 and 5.4.24 and seems to be missing on both.
I'm in production mode and have also set
combine-scripts=true
enable-minification=true
Modules and asset js + css seem to all minify correctly, so look like a
possible oversight for stacks?
Let me know if anyone can confirm/reproduce and a JIRA should be created.
Cheers
Magnus

--
Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

Howard Lewis Ship

2013-11-11 18:38:01 UTC

Permalink

Works for me! I turned off JS aggregation and minification in a client app
and it works exactly as expected.

You probably don't have the tapestry-webresources module in your classpath;
tapestry-core defines the API, but the implementation is in
tapestry-webresources.

Post by Howard Lewis Ship
That sounds like an oversight, and I'm a bit surprised!

--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com

Howard Lewis Ship

2013-11-11 18:39:32 UTC

Permalink

My mistake; I mistook weird end-of-line handling for minification. I'll
look into this.

Post by Howard Lewis Ship
Works for me! I turned off JS aggregation and minification in a client app
and it works exactly as expected.
You probably don't have the tapestry-webresources module in your
classpath; tapestry-core defines the API, but the implementation is in
tapestry-webresources.

Post by Howard Lewis Ship
That sounds like an oversight, and I'm a bit surprised!

--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com